Fix gateway controller deploy target

[mikenairn]

make deploy-gateway-controller deploys both the gateway and policy controller but was only updating the image for the gateway controller to the locally built version. This change updates the make targets to ensure that both the gateway and policy controller images are updated when testing the combined gateway/policy controller installation (e2e tests).

When deploying the controller using a local image loaded into kind, we also need to change the imagePullPolicy to Never or it will never start.

Verification

make local-setup OCM_SINGLE=true
make docker-build-gateway-controller kind-load-gateway-controller docker-build-policy-controller kind-load-policy-controller deploy-gateway-controller

Check the gateway and policy deployments are both using the local image

kubectl get deployments/mgc-policy-controller -n multicluster-gateway-controller-system -o json| jq .spec.template.spec.containers[0].image
"policy-controller:latest"
kubectl get deployments/mgc-controller-manager -n multicluster-gateway-controller-system -o json| jq .spec.template.spec.containers[0].image
"controller:latest"

[mikenairn]

@maleck13 @laurafitzgerald @sergioifg94 The e2e tests are currently not testing what we think they are testing (policy controller is always using the published quay.io main image). If one of you has a minute to review, would be good to get this merged ASAP.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13,mikenairn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[maleck13]

/lgtm