search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
10 stars 23 forks source link

Adresses gh-699 #700

Closed laurafitzgerald closed 9 months ago

laurafitzgerald commented 9 months ago

Addressed #699

quickstart by default the hub cluster is not a spoke cluster docs updates required for quickstart quickstart by default 2 workloads rather than 1

Verification

Some other updates still needed.

Run export MGC_LOCAL_QUICKSTART_SCRIPTS_MODE=true Run sh hack/quickstart-setup.sh

maleck13 commented 9 months ago

code changes look good to me. I am running through the setup and walkthrough locally

maleck13 commented 9 months ago

one thing it might be worth doing is searching for kind-mgc-control-plane to see if there are any other docs that need to change

maleck13 commented 9 months ago

walkthrough went well. All good. Once ready I think we can merge

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: laurafitzgerald, maleck13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maleck13 commented 9 months ago

/lgtm