search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
10 stars 23 forks source link

Fixing prompt text when asking for AWS credentials #705

Closed pmccarthy closed 9 months ago

pmccarthy commented 9 months ago

Summary Fixing the wording used in the quickstart prompts for AWS credentials. Current wording causes confusion as the term secret is used for both the access key and secret key

pmccarthy commented 9 months ago

/lgtm /approve

openshift-ci[bot] commented 9 months ago

@pmccarthy: you cannot LGTM your own PR.

In response to [this](https://github.com/Kuadrant/multicluster-gateway-controller/pull/705#issuecomment-1840797543): >/lgtm >/approve Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
guicassolato commented 9 months ago

/lgtm

pmccarthy commented 9 months ago

/approve

david-martin commented 9 months ago

/approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, guicassolato, pmccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment