search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
10 stars 23 forks source link

#703: Re-add health check components #706

Closed sergioifg94 closed 9 months ago

sergioifg94 commented 9 months ago

Closes #703

Re-add health check monitor and queue, as well as reconciler to policy controller. These components were removed accidentally as part of the separation of controllers

Verification steps

Run the local setup and include a health check section in the DNSPolicy Verify that a DNSHealthCheckProbe is created and the status is updated

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maleck13, sergioifg94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13,sergioifg94] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mikenairn commented 9 months ago

@sergioifg94 Do we not have any tests that check this? Maybe an e2e test that uses health checks in some way would be good to add?

sergioifg94 commented 9 months ago

@mikenairn We only have integration tests and unfortunately they didn't catch this because the health check components didn't get deleted from the test suite. I agree we could use some e2e tests for it. I'll create an issue