Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
10 stars 23 forks source link

Remove namespace on dnsProviderSecretRef to force same namespace as M… #713

Closed david-martin closed 9 months ago

david-martin commented 9 months ago

…anagedZone

Fixes #712

Locally the ManagedZone and dns Secret are in the same namespace:

kubectl get managedzone,secret -n multi-cluster-gateways
NAME                                     DOMAIN NAME      ID    RECORD COUNT   NAMESERVERS   READY
managedzone.kuadrant.io/mgc-dev-mz-aws   dm.hcpapps.net

NAME                         TYPE              DATA   AGE
secret/mgc-aws-credentials   kuadrant.io/aws   3      13m
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maleck13 commented 9 months ago

/lgtm