Make some scripts more generic

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment

Apache License 2.0

10 stars 23 forks source link

Make some scripts more generic #731

Closed adam-cattermole closed 8 months ago

adam-cattermole commented 8 months ago

To be able to re-use some of the functions in the quickstart script for kuadrant-operator I've tried to make them a little more generic:

Made the network in dockerBinCmd overridable by env var instead of set to mgc
Made the namespace for configureController overridable
Renamed quite a few environment variables to KUADRANT_ instead of MGC_

maleck13 commented 8 months ago

/hold

maleck13 commented 8 months ago

@adam-cattermole I am going to rebase main against release-0.3 branch so want to wait until that is done before merging this change. We will pick this up in 0.4

maleck13 commented 8 months ago

/unhold

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adam-cattermole, maleck13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

maleck13 commented 8 months ago

/lgtm