openshift-ci[bot]
commented
9 months ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: david-martin
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/api-upstream/OWNERS)~~ [david-martin]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
R-Lawton
Closes #744 Closes #745
The first commit is a bugfix for something I noticed when making changes. A patch to the number of alertmanager replicas wasn't being applied.
The 2nd commit installs the prometheus, thanos, grafana, kube-state-metrics stack, in the same manner as how it is installed for the mgc metrics quickstart. This sets up metric collection from the components we want (istio, istiod, envoy), and federates the metrics back to thanos in the hub. It also installs some grafana dashboards for mgc use (which are not relevant to stitch api) and some stitch api specific dashboards (imported from the stitch poc private repo).
No data will show up on the new dashboard unless an app is configured in the istio gateway. Therefore it's sufficient to just see the 3 stitch dashboards show up in grafana