search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
11 stars 23 forks source link

Fix Alertmanager name so patch gets applied #757

Closed david-martin closed 8 months ago

david-martin commented 8 months ago

If following the metrics quickstart, alertmanager runs with 3 replicas. This change fixes a patch so that only 1 replica runs (which was the expected behaviour when originally added)

@R-Lawton This makes sense to cherry-pick from #756 back to main as well.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
R-Lawton commented 8 months ago

/lgtm yeah sure ill cherry pick this commit to the api-upstream branch

R-Lawton commented 8 months ago

/lgtm

david-martin commented 8 months ago

ill cherry pick this commit to the api-upstream branch

It's already on that branch. This PR is enough to make sure it's everywhere it needs to be

maleck13 commented 8 months ago

I think if you rebase this it should fix the failing tests. Although with this one I am ok to merge without that

/lgtm