Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
11 stars 23 forks source link

Adding gatekeeper, gatekeeper scorecard and constraints/muatations #760

Closed R-Lawton closed 8 months ago

R-Lawton commented 8 months ago

Added gatekeeper to the local setup as well as gatekeeper scorecard which gives extra metrics and the constraint templates constraints and mutation.

verification

make local-setup-api OCM_SINGLE=true MGC_WORKLOAD_CLUSTERS_COUNT=1 Ensure the script runs with no errors and the components get deployed There wont be any constraint violation unless you make a gateway

david-martin commented 8 months ago

👀

maleck13 commented 8 months ago

I am wondering what the goal is in adding this to the deployment scripts? I already think we should prob slim things down quite a bit. IE remove things like argocd and anything else we don't currenty integrate directly with. We are increasing the maintenance overhead where I think ideally we should be looking for ways to reduce it

david-martin commented 8 months ago

/lgtm /approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, R-Lawton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/api-upstream/OWNERS)~~ [david-martin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment