search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
11 stars 23 forks source link

Use full sha for policy-controller builds #761

Closed adam-cattermole closed 8 months ago

adam-cattermole commented 8 months ago

Updating the policy-controller image build to use the full commit sha

Resolves #759

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adam-cattermole, maleck13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [maleck13] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
maleck13 commented 8 months ago

@adam-cattermole I assume there is no issue with the tag length here?

adam-cattermole commented 8 months ago

@adam-cattermole I assume there is no issue with the tag length here?

Not that I know of, we're using the full sha for our tags for kuadrant -> https://github.com/Kuadrant/kuadrant-operator/blob/main/.github/workflows/build-images-scheduled.yaml#L13-L14

maleck13 commented 8 months ago

These two failing items are known issues so this can be merged /lgtm