search

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment
Apache License 2.0
11 stars 23 forks source link

Add kaudrant resources to ksm permissions #775

Closed david-martin closed 7 months ago

david-martin commented 8 months ago

This has been already applied to the api-upstream branch here, which is needed & referenced by the api-quickstart repo. However, it should land back on main here as well.

R-Lawton commented 8 months ago

/lgtm

mikenairn commented 7 months ago

@david-martin Is this still needed?

david-martin commented 7 months ago

@mikenairn Yes. This will become important if we include metrics and dashboards content like what's in the api-quickstart. Right now that is in the experimental section of the docs site and uses the api-upstream branch, where this change has been made.

mikenairn commented 7 months ago

/lgtm /approve

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin, mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [david-martin,mikenairn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
david-martin commented 7 months ago

Thanks @mikenairn