Remove old code and docs

Kuadrant / multicluster-gateway-controller

multi-cluster gateway controller, manages multi-cluster gateways based on gateway api and policy attachment

Apache License 2.0

11 stars 23 forks source link

Remove old code and docs #777

Closed mikenairn closed 8 months ago

mikenairn commented 8 months ago

Remove redundant docs:

docs/demos/dns-policy - Out of date and hard to maintain with constant changes
docs/proposals - Should all be in the architecture repo now.

ToDo Need to check docs site as it might be referencing some of these.

Remove provider health checks

Remove the provider health checks from the dns provider implementations. Replaced by provider agnostic health checks and there is no mention of these in the docs any longer.

Refactor dns provider code

Move dns provider related code into provider package (dns/provider). Matches external-dns providers and also reduces the chance of import cycle issues.
Rename dns/provider/aws/dns/go -> dns/provider/aws/aws/go (Matches google provider and the naming we will use for future providers).

Note: Not all that has been agreed yet, the PR will remain a draft until then.

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikenairn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/Kuadrant/multicluster-gateway-controller/blob/main/OWNERS)~~ [mikenairn] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

mikenairn commented 8 months ago

@maleck13 @philbrookes Could you take a look at this and see if we are happy enough with removing the docs and provider health checks.

The health checks i don't really see the need to keep the code and would rather just remove it now if we can, provider agnostic health checks are what we support AFAIK, and we have no intention of implementing provider health checks for other providers. The docs removal, i want to get rid of docs/demos/dns-policy as it's just always out of date, but wasn't so sure about proposals, can undo that if we think there is value in leaving it.

mikenairn commented 8 months ago

Closing in favour of https://github.com/Kuadrant/multicluster-gateway-controller/pull/780