Closed mikenairn closed 4 months ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
I think it is reasonable to remove the skupper and submariner docs at this point. We don't ever test them and really if you use gateway API and use an e/w technology that either support multi-cluster service or a regular service we will be able to work with it. Changes look fine.
Will run a local-setup to verify
local setup completed so happy to merge /lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: maleck13, mikenairn
The full list of commands accepted by this bot can be found here.
The pull request process is described here
refactor: remove unnecessary dependencies
refactor: Align local-setup and quick-start deployment paths
Updates local-setup to use the same kustomizations as the quick start scripts. Installation and configuration of hub and spoke dependencies is now consistent across both deployment paths.
The only difference between quick start and local setup now is that metrics is enabled by default with local-setup, managedzones and dns providers are created using local environment files instead of environment variables and the MGC gateway controller is not running on the hub cluster.
Note: The skupper POC docs are listed in our docs site and would need to be removed before the next release if we merge this as is. Personally i see no advantage to leaving these here.