search

Kuadrant / testsuite

3 stars 12 forks source link

Fix keycloak fixture unknown variable #446

Closed averevki closed 2 months ago

averevki commented 2 months ago

request variable is required to add a realm clean-up finalizer to the fixture

trepel commented 2 months ago

Hmm, I spent some time figuring out how this happened. It seems that GH allowed to merge https://github.com/Kuadrant/testsuite/pull/440 despite it not being rebased on main. And since https://github.com/Kuadrant/testsuite/pull/431 got into main in the meantime and GH did not detect the conflict it led to this bug (if my analysis is correct). Any idea what to do to avoid this in the future?

pehala commented 2 months ago

And since #431 got into main in the meantime and GH did not detect the conflict it led to this bug

Well there was no conflict from git point of view, GH could not detect it.

Any idea what to do to avoid this in the future?

I think it is rare enough to not care that much about it. There is an option to always require PR to be up-to-date with main before merging but I believe that will slow down merging process for PRs even more as you need to rebase everytime something else is merged.

trepel commented 2 months ago

Ok, thanks. We can always revisit if this started happening more often.