search

Kuadrant / testsuite

3 stars 12 forks source link

Remove need to specify committed property #452

Closed pehala closed 1 month ago

pehala commented 2 months ago

Advantage: No need to specify committed when fetching object from Kubernetes Disadvantage: One call to Kubernetes to check if it exists per object (it is cached)

Let me know what you think :)

averevki commented 2 months ago

It looks good, actual up-to-date state on objects overweight disadvantages for me :+1:

Disadvantage: One call to Kubernetes to check if it exists per object (it is cached)

What's cached? Committed property or API request?

pehala commented 2 months ago

Property, so rhe call is not repeated

jsmolar commented 1 month ago

I like this change committed = True after the selector always bothered me more than it should.
Let's "undraft" this.