search

Kuadrant / testsuite

3 stars 12 forks source link

Remove preexisting authorino #466

Closed jsmolar closed 3 weeks ago

jsmolar commented 1 month ago

We don't use preexisting authorino (at least, I am unaware of it). I propose to remove unnecessary code for the authorino/operator package and the authorino fixture.

I would like to add another topic for discussion. operator/conftest.py and authorino/conftest.py contain the same "copy-pasted" authorino fixtures, only the scope is different. Is there a good solution for this?

trepel commented 1 month ago

I tried to run test_deploy_authorino.py, passed. So LGTM, just two questions.

Should not PreexistingAuthorino class be removed as well? It is no longer used: https://github.com/Kuadrant/testsuite/blob/main/testsuite/openshift/authorino.py#L113

Here is some suspicious code that looks like containing some leftovers that could be removed? Not 100% though: https://github.com/Kuadrant/testsuite/blob/main/testsuite/config/__init__.py#L36-L39