search

Kuadrant / testsuite

3 stars 12 forks source link

Add identical hostnames tests for desired behavior #477

Closed trepel closed 1 month ago

trepel commented 1 month ago

Overview

Last piece to address https://github.com/Kuadrant/testsuite/issues/406

Follows up on https://github.com/Kuadrant/testsuite/pull/439 and https://github.com/Kuadrant/testsuite/pull/462 which added similar tests for AuthPolicy and RateLimitPolicy (RLP) respectively, but these tests validating current behavior.

The tests in this PR cover two scenarios, both testing desired behavior. Desired behavior means that Kuadrant does not behave like that yet so the tests are expected to fail. Once they start passing it means that implementation has changed and it would be good to take a closer look how and if that makes sense and update the testsuite accordingly.

Scenario 1.

Test that 2nd Gateway-attached AuthPolicy is actually enforced on route (currently it states that it is enforced but effectively it is ignored)

Scenario 2.

Test that 2nd HTTPRoute-attached AuthPolicy is enforced (currently it fails with an error, status being Enforced=False)

Scenario 3.

Test that the 1st HTTPRoute-attached RLP is effectively enforced (currently it is effectively ignored because the 2nd HTTPRoute-attached RLP "kicks" it off)

Verification Steps

Run the three tests. Or even better run the whole dir with all the "identical hostname" tests. 4 tests should pass, 3 should be xfailed. It should take roughly 8-9 minutes:

$ make testsuite/tests/kuadrant/identical_hostnames/
...
======= 4 passed, 2 xfailed in 473.34s (0:07:53) =======
pehala commented 1 month ago

Needs rebase due to #473 (sorry :D)

trepel commented 1 month ago

Needs rebase due to #473 (sorry :D)

Grrrr! :) Rebased!