Kuadrant / wasm-shim

A Proxy-Wasm module allowing communication to Authorino and Limitador.
Apache License 2.0
5 stars 5 forks source link

Metadata action type #22

Closed rahulanand16nov closed 2 years ago

rahulanand16nov commented 2 years ago

10

Implements metadata acton type along with some unit tests.

I have not done the end-to-end test yet because changes are required in the Kuadrant controller before we test the user-id-based rate limit.

eguzki commented 2 years ago

I have not done the end-to-end test yet because changes are required in the Kuadrant controller before we test the user-id-based rate limit.

You can test locally with the docker compose env. No need for the kuadrant's env to test it.

rahulanand16nov commented 2 years ago

I have not done the end-to-end test yet because changes are required in the Kuadrant controller before we test the user-id-based rate limit.

You can test locally with the docker compose env. No need for the kuadrant's env to test it.

I need some way to set the dynamic metadata which is done by Authorino. :thinking:

Edit: Found something helpful: https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/header_to_metadata_filter#config-http-filters-header-to-metadata

rahulanand16nov commented 2 years ago

@eguzki I have used the header-to-metadata filter and updated the local development configuration to use metadata action. LGTM.

rahulanand16nov commented 2 years ago

@eguzki Okay to merge now?