search

Kuadrant / wasm-shim

A Proxy-Wasm module allowing communication to Authorino and Limitador.
Apache License 2.0
5 stars 4 forks source link

Clippy Allowing warnings #80

Closed didierofrivia closed 1 week ago

didierofrivia commented 1 week ago

In order to fix https://github.com/Kuadrant/wasm-shim/actions/runs/10735988827/job/29774629002?pr=77

alexsnaps commented 1 week ago

Whichever route you all decide to take, I'd like for it to remain a temporary fix until this PR is released into a newer version of the crate... thanks 🙏

eguzki commented 1 week ago

Whichever route you all decide to take, I'd like for it to remain a temporary fix until this PR is released into a newer version of the crate... thanks 🙏

Good to see there is a fix. Indeed, we need just a temporary fix (and a reminder to undo when the upstream fix is available)

Currently:

* 0beff241 - (3 weeks ago) Update CHANGELOG.md - Stepan Koltsov (HEAD -> master, origin/master, origin/HEAD)
* 60c7e3c3 - (3 weeks ago) Remove protoc version check because they changed versioning - Stepan Koltsov
* 0dcd7e3c - (5 weeks ago) Remove use of box_pointers lint - Rob Ede
| * 1e1e80ad - (3 weeks ago) Bump version to 3.5.1 - Stepan Koltsov (tag: v3.5.1, origin/v3.5)
| * 2b893299 - (5 weeks ago) Remove use of box_pointers lint - Rob Ede
| * 22655e35 - (3 months ago) Bump version to 3.5.0 - Stepan Koltsov (tag: v3.5.0)
| * 7843e95d - (3 months ago) Regnerate protos - Stepan Koltsov
| * 515bfe02 - (3 months ago) Bump version to 3.5.0-pre - Stepan Koltsov
|/  
* 0e6f3ff5 - (3 months ago) Disable miri test which seems to run too slowly - Stepan Koltsov

The fix we want is 0dcd7e3c - (5 weeks ago) Remove use of box_pointers lint - Rob Ede

didierofrivia commented 1 week ago

@eguzki Added a TODO comment pointing out the PR that needs to be released