Kuanhao-Chao / LiftOn

🚀 LiftOn: Accurate annotation mapping for GFF/GTF across assemblies
http://ccb.jhu.edu/lifton
GNU General Public License v3.0
48 stars 1 forks source link

Fix a missing import and actually run the tests #13

Closed kdm9 closed 1 week ago

kdm9 commented 2 weeks ago

Hello,

Lifton seems a promising tool, however there is a bug that prevents execution: the code imports a module that doesn't exist (lifton.mapping).

I've fixed that, but I've also added a github action config to run the example/test you have, which would have caught this issue when it was first made. Strangely installing from pip seems to work alright, but there is another bug I'm trying to track down, and after installing from git with pip install -e ., lifton doesn't work.

best, Kevin

kdm9 commented 2 weeks ago

by the way, the tests won't run here till you approve the pull request (or maybe even merge it). But, they have run on my fork here: https://github.com/kdm9/LiftOn/actions/runs/9859290868/job/27222666828

Kuanhao-Chao commented 1 week ago

Hi @kdm9 Thanks for fixing this issue and adding a github action config. I will address your github issue soon