Kubis10 / CounterForMessenger

Counter for Messenger - First and most extensive free desktop application made in Python with tkinter
https://kubis10.github.io/CounterForMessengerPage/
Other
20 stars 28 forks source link

Add better sorting #29

Closed Kubis10 closed 5 days ago

Kubis10 commented 1 year ago

Add better sorting method in main view (ex: add option to sort by chat type and messages count in the same time) and sort people in groups in "more stats" by default by messages count, add option to filter data.

Abhijeet-1409 commented 1 year ago

can i take this issue ?

Kubis10 commented 1 year ago

Sure

cremick commented 12 months ago

Hi, is this issue still open? I would love to work on it

Kubis10 commented 12 months ago

@cremick Hi, yes it is still open so if you have any questions, feel free to ask

Coder2Mo commented 11 months ago

if i may i will work on this too

Kubis10 commented 11 months ago

No problem

tkroening commented 6 months ago

Hi!

We're a team of five looking to contribute to an open source project as part of our Software Engineering class. We were wondering if this issue is still a problem, and whether we could work on it?

Thank you for your time!

Kubis10 commented 6 months ago

@tkroening Yes, the task is still to do. I would appreciate your help thanks!

tkroening commented 6 months ago

Our team has made some progress on the "sorting" component of this issue. See this draft PR for a screenshot and a video demo. The new popup implemented in this PR would allow users to sort on any arbitrary combination of columns they like.

What do you think? Are there any additional features or UI changes that we could add?

Thank you!

Kubis10 commented 6 months ago

@tkroening I like it, but I think it would be better if Column names were the same as in main view also it would be great if this menu remembers what user input before

tkroening commented 6 months ago

Thank you for your feedback! I've updated the PR with some changes that try to implement your suggestions. Do the changes implement what you had in mind?

Kubis10 commented 6 months ago

Now better, but reverse and remove buttons are not working

tkroening commented 6 months ago

Thank you for your reply! May I ask how to reproduce this issue? I only ask because the way I implemented those buttons was to read the selection from the left column.

I agree that this is pretty bad UX. There might be a way to detect which listbox is active, and have the buttons use that instead.

Kubis10 commented 6 months ago

I get it now. I think it's not intuitive, and it won't be for people either, so it would be useful to somehow change the UI or give some hints on how it works

Chen3018 commented 6 months ago

Just for clarification, is the filtering option for the main view? Or should it be for the statistic view as well?

Kubis10 commented 6 months ago

Generally, the task was to make the messages sorted by default by the number of messages, the same in individual statistics for groups, etc., and to make the sorting options more advanced in the main view, as you have done now

tkroening commented 6 months ago

it would be useful to somehow change the UI or give some hints on how it works

I agree! I think part of what makes it un-intuitive is that a user would expect to be able to use those buttons even when they've selected something in the right column.

So, my proposed solution is to check both columns for a selection when those buttons are pressed. Here's a demo: Demo

The PR has been updated with the code. Is this what you had in mind?

Kubis10 commented 6 months ago

Now it's great, as for the code, I would only ask you to separate the entire text in the UI as values for translations and I think it will be okay with this part

tkroening commented 6 months ago

I've updated the popup with support for localization, and added translations for the other languages. I used an LLM (Google Gemini) to generate the translations for the other languages, so I can't vouch for their correctness (except for the German). I've marked all of them as "NEEDS REVIEW".

Would you rather I just leave in the original English strings or are those translations okay?

Another question our team had is whether we could help work on some of the other things mentioned in the original issue:

add option to filter data

sort people in groups in "more stats" by default by messages count

Would these still be helpful? Since we're a team of five, we could definitely try to work on a filtering feature, or improvements to the "More statistics" view.

Thank you again for your time!

Kubis10 commented 6 months ago

Sure, I would appreciate your help with these subtasks. Thanks!

tkroening commented 6 months ago

I've made a PR (#56) that adds the sorting component mentioned in this issue. Let me know if I can make any changes.

Thank you!

cathyxfeiyang commented 6 months ago

I've updated the profile and statistics popups (linked in this PR: https://github.com/tkroening/CounterForMessenger/pull/3):

Would these be helpful to the project? Let me know if I can make any changes.

Thank you!