Kubis10 / CounterForMessenger

Counter for Messenger - First and most extensive free desktop application made in Python with tkinter
https://kubis10.github.io/CounterForMessengerPage/
Other
20 stars 28 forks source link

Implementation of Interpolating the username through the given data #45

Closed ippokratis12 closed 11 months ago

ippokratis12 commented 11 months ago

Description

For starters i created a function in the MasterWindow called find_user_in_conversations. In this function i find the username of the user. This function basically is pretty simple. Firstly i find the conversations in which there are only two participants. After doing that i'm trying to find the same name twice in two different conversations. Doing that i find the name of the user because we already know that the conversations belong to the user. So finding the same name in two different conversations means that this name is the user's username. When we find the username we return it.

Also i needed to change the open_file_explorer function in ConfigurationPage class and in SettingsPopup class in order to take properly the name from function find_user_in_conversation and put the username in the entry box. Basically whenever the user choose the directory either from the configuration page or from the settings it automatically finds the user's username. However when you open the settings you can also put some other name there if the user wants to. But each time you choose the directory the user's username is found automatically.

In the end i also created a deutch.py file

Fixes # (issue)

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

I tested it with the json files i downloaded from my account in facebook

Test Configuration:

Checklist:

ippokratis12 commented 11 months ago

do i need to do anything more? Or are you going to merge this function to the main branch? If needed i can make another pull request with your changes. Let me know

Kubis10 commented 11 months ago

Just add this to your fork and commit it, I will merge it

Kubis10 commented 11 months ago

Great work

ippokratis12 commented 11 months ago

Now do i close the pull request or do i need to do anything about the merge section? Or are you going to handle the rest?

Kubis10 commented 11 months ago

I will handle this