search

Kudo / jsc-android-buildscripts

Script for building JavaScriptCore for Android (for React Native but not only)
BSD 2-Clause "Simplified" License
11 stars 6 forks source link

GC concurrent issue potential fix #1

Closed tosbaha closed 4 years ago

tosbaha commented 4 years ago

Fixes from @pratikpatel39 according to this issue

Kudo commented 4 years ago

Thank you @tosbaha, do you mind to put the original WebKit patch directly? It would be better to appreciate original author's work. It seems your branch has the permissions for me to edit directly. If you don't mind, I could edit on your branch and then merge your PR.

tosbaha commented 4 years ago

Hi @Kudo , I got the combined patches from the linked thread. Which actually links to https://trac.webkit.org/changeset/251307/webkit Since the patches were pointing to the different directories, @pratikpatel39 fixed the patches and unified the patch. I don't know how can I put the original WebKit patch directly. I checked the patches in this repository there were no authors etc. Please edit the PR as you please.

Kudo commented 4 years ago

Sorry to make you confuse. I was talking about including the CHANGELOG. Will modify your PR and merge directly. Thank you very much.

Kudo commented 4 years ago

I've modified your PR and merged back to jsc_2_26_1 branch. Will follow up to merge this patch to my develop branch and hopefully to publish new version soon. Thank you.