Fix build on React Native 0.69

Kudo / react-native-v8

Opt-in V8 runtime for React Native Android

MIT License

914 stars 69 forks source link

Fix build on React Native 0.69 #126

Closed ammarahm-ed closed 2 years ago

ammarahm-ed commented 2 years ago

Hey, so I was finally able to make v8 work with react-native 0.69.

Use folly_runtime instead of folly_json for react-native 0.69
Extraction of separate aar files for debug and release.
Add missing createPropNameIDFromSymbol method. Although I am not sure if I have done it the right way. I am glad that my app is running again at least.

closes #125

Thank you for v8 in react-native.

ammarahm-ed commented 2 years ago

Do you mind if i create a pr for same purpose but adding you as a co-author?

Yes, that would be fine. I am just glad it's working on my side since I needed to release an update.

Kudo commented 2 years ago

i've updated for 0.69 support and added you as a co-author in the commit. thanks for your contribution. close via b7e07262eb88e834629fc5167b4d12434f170ccc