search

Kudo / react-native-v8

Opt-in V8 runtime for React Native Android
MIT License
914 stars 69 forks source link

suppress unused-variable warning #143

Closed Sunbreak closed 1 year ago

Sunbreak commented 1 year ago

On branch 0.69-v8 of https://github.com/Sunbreak/react-native, when bundleReleaseAar

$ ./gradlew :ReactAndroid:bundleReleaseAar
ReactCommon/jsi/v8runtime/V8Runtime.cpp:582:25: error: unused variable 'v8PointerValue' [-Werror,-Wunused-variable]
    const V8PointerValue *v8PointerValue =
                          ^
  1 error generated.
Sunbreak commented 1 year ago

thanks for this pr. just a nit comment there, please help to take a look. thanks!

Done. Could you take another look?