search

Kudo / react-native-v8

Opt-in V8 runtime for React Native Android
MIT License
900 stars 69 forks source link

[0.72] Build error in android #175

Closed NiuGuohui closed 1 year ago

NiuGuohui commented 1 year ago

Package info: "react-native": "0.72.0-rc.1", "react-native-v8": "^2.1.3", "v8-android-jit-nointl": "^11.110.1"

ndkVersion = "24.0.8215888"

Build console output: Task :react-native-v8:buildCMakeDebug[arm64-v8a][v8executor] FAILED

In file included from xxxx/node_modules/react-native-v8/src/v8runtime/JSIV8ValueConverter.cpp:8: In file included from xxxx/node_modules/react-native-v8/src/v8runtime/JSIV8ValueConverter.h:10: xxxx/node_modules/react-native-v8/src/v8runtime/V8Runtime.h:156:42: error: non-virtual member function marked 'override' hides virtual member functions

NiuGuohui commented 1 year ago

@Kudo Hello, can you take a look at this question?

NiuGuohui commented 1 year ago

I fixed it. #176

valeshgopal commented 1 year ago

I am getting the same error Task :react-native-v8:buildCMakeDebug[v8executor] FAILED in react native 0.68.2. Is there a fix for it as well?

Kudo commented 1 year ago

the 0.72.0 support is resolved by react-native-v8@2.2.0. thanks!