search

Kuifje02 / vrpy

A python framework for solving the VRP and its variants with column generation.
MIT License
179 stars 43 forks source link

Dead code ? #6

Closed Kuifje02 closed 4 years ago

Kuifje02 commented 4 years ago

Did you write this bit of code for a particular reason ? I may be wrong but I don't think it is ever read (tests pass when it is commented).

https://github.com/Kuifje02/vrpy/blob/662ad3961891ba3556bbf71f8e3b608996de8a42/vrpy/subproblem_lp.py#L14-L18

torressa commented 4 years ago

Hey, it doesn't fail because they get redefined after you call formulate in https://github.com/Kuifje02/vrpy/blob/662ad3961891ba3556bbf71f8e3b608996de8a42/vrpy/subproblem_lp.py#L53-L55

I think the attributes for the class should be called in the init method. However with the inheritance you need to explicitly pass the arguments you don't want to the parent class

torressa commented 4 years ago

Take a look. Sorry for the reformating again

torressa commented 4 years ago

Also, can't figure out why the tests are failing... :thinking:

Kuifje02 commented 4 years ago

No problem for the formating. I use black. Which one do you use ? I can switch to yours I have no preference