search

Kuinox / NupkgDeterministicator

Make your NuGet packages deterministic
MIT License
8 stars 2 forks source link

[Improvement] Handle common exceptions #1

Closed BinToss closed 2 months ago

BinToss commented 2 months ago
Kuinox commented 2 months ago

Oh hello, I'm surprised someone is using this after this long !

Cannot deterministicate a nupkg/snupkg that is already deterministic

Yes, i'll add a check for this.

Add help (-h/--help) argument An argument like this, which always exits with code 0, would be helpful in cross-platform MSBuild tasks to check if NupkgDeterministicator is installed before executing it after Pack.

Ideally I should rewrite the entrypoint with System.CommandLine, which also handle transparently msbuild response file.

I will do it tomorrow or this we, you can also PR it if you want.

BinToss commented 2 months ago

I didn't expect such a quick response! I think I can open a PR for the help arg tonight if I rush it.

Kuinox commented 2 months ago

Mind that when it will be rewritten with system.command line the help prompt will be triggered differently than the very simple in-test there is right now.

BinToss commented 2 months ago

All sub-issues resolved.