Closed hh1985 closed 4 years ago
Dear Han,
Sorry for not responding sooner. I've been quite busy the past few days. I'll try and take a look at this today.
All the best, Craig
Dear Han,
Thank you for your detailed review of my code. This is the first time I have worked with wiff type files. I think the bug can be attributed to that. I added some if statements to acquire scan number information from the column "spectrum" as you pointed out above. Please run the updated version of the code from github and let me know if you were able to run it. I was not able to reproduce your error, as I could not load the files into xcms. Could you please send me a script on how you are loading data into AutoTuner? I'd like to include the functionality to handle wiff files into other parts of the software. Hopefully, the changes let you run you Autotuner despite this.
All the best, Craig
Hi Craig,
I converted the wiff files into mzML format through msconvert or Proteowizard. In order to do the conversion on Linux server, I use docker to do that: https://hub.docker.com/r/chambm/pwiz-skyline-i-agree-to-the-vendor-licenses
-Han
On Mon, Jul 6, 2020 at 11:10 PM crmclean notifications@github.com wrote:
Dear Han,
Thank you for your detailed review of my code. This is the first time I have worked with wiff type files. I think the bug can be attributed to that. I added some if statements to acquire scan number information from the column "spectrum" as you pointed out above. Please run the updated version of the code and let me know if you were able to run it. I was not able to reproduce your error, as I could not load the files into xcms. Could you please send me a script on how you are loading data into AutoTuner? I'd like to include the functionality to handle wiff files into other parts of the software. Hopefully, the changes let you run you Autotuner despite this.
All the best, Craig
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/crmclean/Autotuner/issues/29#issuecomment-654296860, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVZ7ZHLDBBBPWBKT4ZKGZLR2HSNBANCNFSM4ONCHYKQ .
Ah, gotcha. One of the docs for xcms said it would accept wiff files if you loaded both the original and the scan file, but I wasn't able to figure it out in a short amount of time. If the solution does not work, would you mind sending me a few of the mzML files you generated?
@crmclean Absolutely not.
@crmclean The updated commit didn't work. I added a few lines in EICParams.R and this works for me:
header <- suppressWarnings( MSnbase::header(msnObj))
# -- Begin: fix the header scanId problem
scanID <- as.numeric(sub("(.* )?scan=|(.* )?scanId=", "", header$spectrumId))
if (any(is.na(scanID))) {
header$spectrumId <- stringr::str_c(header$spectrumId, " scanId=", header$spectrum)
}
# -- End
allMzs <- MSnbase::mz(msnObj)
BTW, I am trying to benchmarking the tuning algorithms (MetaboAnalystR 3, IPO, Autotuner) using dataset from Li et al. 2018 Comprehensive evaluation of untargeted metabolomics data processing software in feature detection, quantification and discriminating marker selection
The results are interesting: Autotuner gives more identified peaks, but quantification is not as good as others. I will dig more into it.
Thanks for the fix! I'll update the code. Super curious, what do you mean by "quantification"?
@crmclean The actual log ratio vs. the expected log ratio (ground truth).
Gotcha. Thanks for clarifying.
Hi,
I tried to process metabolomics data and met followig error:
Error: There was a problem finding spectrum IDs within header file for this data. Error occured after function 'dissectScans'.
By debugging the function
dissectScans
,I found that
scanID
returnsNA
due to the invalid value ofpeakHead$spectrumId
:sample=1 period=1 cycle=233 experiment=1
which contained noscan
orscanId
information.Other columns such as
spIdx
,acquisitionNum
, andspectrum
are fineThis looks like a bug. Just wonder if the scanID information can be extracted from other columns if scanId can not be found.
The test data is from https://drive.google.com/drive/folders/1PRDIvihGFgkmErp2fWe41UR2Qs2VY_5G AB TripleTOF 6600 datasets
Thanks,
-Han