search

Kukks / BTCPayServerPlugins

MIT License
25 stars 25 forks source link

NIP-57 Integration Issue/Feedback #10

Open MSauce opened 1 year ago

MSauce commented 1 year ago

Thanks again for working on this. Posting what I sent on nostr here about the NIP-57 integration.

  1. Zappr private key should be allowed (optionally) to be different than the zap recipients private key. Ideally delegation could be accepted here too.

  2. If someone tries to pass a comment with the zap, the invoice generation fails.

Kukks commented 1 year ago

Point 1.) should be done in latest version. The server will generate a key and use that for zaps, unless the user specified their own key, in which cased it will sign with that instead

MSauce commented 1 year ago

Great work!

Perlover commented 1 year ago

And please fix this problem: https://github.com/Kukks/BTCPayServerPlugins/issues/14

Kukks commented 1 year ago

And please fix this problem: #14

Please don't "bump" separate issues like this.

MSauce commented 1 year ago

I tested the new version recently, and can't seem to get a 9735. Perhaps I'm doing something wrong. I am trying to enter my pubkey but leave the private key blank (or optionally it would be nice to able to set it to a different private key not associated with the pubkey).

I checked the logs and I see the the "Zapping 1 to ..." for each relay I submitted (as well as the user send the zap's relays) but the event doesn't seem to be written anywhere.

It works as before if I use a public/private key combo. It is quite slow though, sometimes the zapper doesn't start until 1 minute after it detects the payment. Also, I tried adding a comment and that seems to be working as well now as long as the "Allow payee to pass a comment" is enabled in LNURL settings.

Kukks commented 1 year ago

I tested the new version recently, and can't seem to get a 9735. Perhaps I'm doing something

It is slow on purpose to prevent dos issues. It batches and send zaps every 2 minutes or if there are more than 10 pending zaps events to send.

remcoros commented 4 months ago

Did you get this working?

I've setup BTCPay server, a lightning address, the Nostr plugin, etc.

I can send zaps and they show up. But when I receive zaps, they don't show up in any Nostr client. (the sats are received on my node though!)

Following the BTCPayServer logs it does show that it sends the receipts:

2024-05-29T18:47:42+02:00  info: BTCPayServer.Plugins.NIP05.Zapper: Attempting to send 1 zap receipts
2024-05-29T18:47:42+02:00  info: BTCPayServer.Plugins.NIP05.Zapper: Zapping 1 to wss://nostr.sudocarlos.com
2024-05-29T18:47:42+02:00  info: BTCPayServer.Plugins.NIP05.Zapper: Zapping 1 to wss://relay.mostr.pub
2024-05-29T18:47:42+02:00  info: BTCPayServer.Plugins.NIP05.Zapper: Zapping 1 to wss://relay.damus.io
etc.

But in Nostr clients it doesn't show (I tried primal, snort, nostrudel, coracle).

Am I doing something wrong? Is there an easy way to verify the zap receipts are actually valid?

btcpayserver 1.13.1 Nostr plugin 1.1.8.0

Well, right after I wrote this post I received a random zap that does show up... but when I'm testing with a test account/test wallet zapping my main npub, it doesn't work... I have no idea what's going on now.

remcoros commented 3 months ago

The latest version fixed an issue that Zap receipts were being rejected by relays when the Zap request content (description) contained UTF8 characters (like emojis). From my own testing, it all seems to work again now!