Extracting uri from identifier doesn't work well for onion and port

Kukks / LNURL

a C# implementation of LNURL

MIT License

21 stars 10 forks source link

Extracting uri from identifier doesn't work well for onion and port #5

Closed jbojcic1 closed 2 months ago

jbojcic1 commented 1 year ago

By looking at the code of ExtractUriFromInternetIdentifier method I noticed that you want to support port within identifier too. However that doesn't seem to work well if domain is onion. See the example here

So for value test@nakamoto.onion:4000 the URI ends up being HTTP.