search

Kukuza / mobile-wallet

Kukuza Mobile Wallet for Celo
Apache License 2.0
10 stars 1 forks source link

See splash screen after posting top up request, and existing requests disappear. #743

Open steffenkrogmann opened 2 years ago

steffenkrogmann commented 2 years ago

  1. With the new build, I was able to install, get in, and create an account (good, previous one didn't work).

  2. I see these requests when logging in. image

  3. First try, i get the "no gas" error, as expected (good): image

  4. I was able to get test funds from the faucet (address visible, good).

  5. Once I tried to submit a new request, an overlay with a loader did not appear as expected. Instead I immediately saw the Splash screen.

  6. In order to get out, I have to restart the app.

  7. After restarting, the requests that showed earlier in the feed are not there anymore. Feed is empty.

Google pixel 4, Android 12.

Allen-Muhani commented 2 years ago

When the app closes the kits are destroyed. You need the PIN to recreate an instance that can sign transactions. The whole logic needs to be reorganized.

Allen-Muhani commented 2 years ago

As of now, we can create a session (the private key stored in the RAM after decryption) thanks to the mnemonic (creation, storage, encryption, and decryption).

What needs to happen is that redux needs to be properly configured so that every component in the app has access to the side effects of the state variables relevant to it. Also, we need to do utils that are only relevant for signed transactions.

This allows us to open the PIN modal/screen asking for the PIN, after that, we decrypt the mnemonic. If successful we can then proceed and perform the transaction with the private key which is the aftermath of the previous process. If the process is successful. Display the appropriate response.

The above needs to be done with progress and error display in mind if not we will revisit this discussion at some point in the future.

steffenkrogmann commented 2 years ago

@Allen-Muhani i understand, based on what you mentioned yesterday.

Just wanted to keep track of the bug.

Allen-Muhani commented 2 years ago

Cool