search

Kukuza / sargo-smart-contracts

Smart Contracts for P2P On- and Off-Ramp on Celo
Apache License 2.0
1 stars 0 forks source link

Add properties for currency and country to P2P transactions/requests #34

Open steffenkrogmann opened 2 years ago

steffenkrogmann commented 2 years ago

In the (near) future we want to be able to filter transactions in the feed. Based on:

  1. currency
  2. country

We don't know yet, how exactly we will filter. But what we do know is that

  1. The user sets his/her display currency in the front end.
  2. The user specifies what country he/she is from.

Does it make sense to add bother properties to the smart contract?

What we haven't figured out yet: What if a user sets his display currency to KSH, but chooses the country "Nigeria" when posting a request?

Allen-Muhani commented 2 years ago

For now we only have the currency code stored onchain

steffenkrogmann commented 2 years ago

@dmutinda what are your thoughts on this?

Is currency enough or is there a need to also have country?

on the front end, the user picks country. i guess that is where we would force the user into that countries currency, right? so we should be good with jsut currency?