search

Kukuza / sargo-smart-contracts

Smart Contracts for P2P On- and Off-Ramp on Celo
Apache License 2.0
1 stars 0 forks source link

add successful transaction counter #9

Closed Allen-Muhani closed 2 years ago

steffenkrogmann commented 2 years ago

@Alphonce-Mutebi did you test the functionality of the contract in Remix (or something similar)?

Alphonce-Mutebi commented 2 years ago

@Alphonce-Mutebi did you test the functionality of the contract in Remix (or something similar)?

Pulled and ran the test locally on VS Code

steffenkrogmann commented 2 years ago

@Alphonce-Mutebi it is good that you added the logs, but can you file those as a bug? PR might be closed, merged or deleted.

To be specific: Since you approved the changes, the logs you posted will disappear. You basically raised a bug but approved anyway. that is why the bug needs to be separate.