search

KulkarniAdwait / TwitterFull

0 stars 0 forks source link

My "Full" Twitter app is complete. Please review. #1

Open KulkarniAdwait opened 10 years ago

KulkarniAdwait commented 10 years ago

My app is complete. I had 2 questions:

  1. I couldn't get the feed to refresh after when the user clicks the inline reply button and replies. I tried putting the fragment.refreshFeed() in onResume() of the activity that holds the fragments but it was crashing. Using the same fragment.refreshFeed() refreshes the feed when I compose a tweet by clicking on the compose button in the action bar and then come back to the feed. Is this because I using startActivityForResult() and on the onResult() I am able to refresh the feed?
  2. The pull to refresh would just hang. I was calling onRefreshComplete(), have I rigged up the fragments wrong? Because I was able to get it working when I have a vanilla activity and an "endless" listview. /cc @nesquena
nesquena commented 10 years ago

Nice work! Good to see you got some styling in and played with ViewPager. :+1: Project looks good. I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.

nesquena commented 10 years ago
  1. I couldn't get the feed to refresh after when the user clicks the inline reply button and replies. I tried putting the fragment.refreshFeed() in onResume() of the activity that holds the fragments but it was crashing. Using the same fragment.refreshFeed() refreshes the feed when I compose a tweet by clicking on the compose button in the action bar and then come back to the feed. Is this because I using startActivityForResult() and on the onResult() I am able to refresh the feed?

What exception were you getting specifically? May want to check helpful hints to see if it addresses the issue based on the exception.