search

Kully / pixel-paint

An art tool for making 32x32 Sprites
https://kully.github.io/pixel-paint/
389 stars 25 forks source link

Add classic Gameboy color palette #11

Closed R-Lovelett closed 1 year ago

R-Lovelett commented 2 years ago

I saw your project and really enjoy how you created the accurate color palette for the NES to use. I would love to contribute by adding a toggle to switch to another palette - particularly the classic Gameboy with its 4-color green monochrome. Would that be alright?

Kully commented 2 years ago

@R-Lovelett Yes that would be amazing! Really happy that you are showing interest in the project.

For sure, I'm happy for you to set up a little toggle between NES and classic Gameboy.

Feel free to fork the project and create the PR. Also happy to look at your code along the journey if you want some 👀 on it.

R-Lovelett commented 2 years ago

Great! I appreciate the support! I'll most likely work on it more over the weekend, but I've been brainstorming and think it would be neat to have a toggle that would show/hide the appropriate color palettes while selected. I have a couple ideas on how this could potentially be accomplished, but I'll keep you posted in case I need a second set of eyes.

Kully commented 2 years ago

Great! I appreciate the support! I'll most likely work on it more over the weekend, but I've been brainstorming and think it would be neat to have a toggle that would show/hide the appropriate color palettes while selected. I have a couple ideas on how this could potentially be accomplished, but I'll keep you posted in case I need a second set of eyes.

Sounds great! Yeah, let me know what you are thinking. Would be happy to 👀 at it.

R-Lovelett commented 1 year ago

I spent some time yesterday night implementing the toggle I had mentioned to you before. I opted for radio buttons to switch out the color palettes depending on which one is considered "checked". If you'd like to take a look at the forked repository, I would be happy to show you what I've got so far.

Kully commented 1 year ago

I spent some time yesterday night implementing the toggle I had mentioned to you before. I opted for radio buttons to switch out the color palettes depending on which one is considered "checked". If you'd like to take a look at the forked repository, I would be happy to show you what I've got so far.

Hey! Yes I'd love to see what you have so far. Let's see the forked repo! :)

Kully commented 1 year ago

@R-Lovelett https://github.com/Kully/pixel-paint/pull/13