search

Kuma-Boo / project-reignition

A remake of Sonic and the Secret Rings
Other
27 stars 5 forks source link

[Request] High framerate support #103

Open ActualMandM opened 3 months ago

ActualMandM commented 3 months ago

Describe the limitation

In the current version, the gameplay itself operates at 60 FPS. This is fine, but can be visually distracting for people with high refresh rate monitors. This is made worse with certain objects still operating at the monitor refresh rate, like the rings.

Describe the new feature and it's purpose

Having the game automatically adjust the physics framerate according to the current refresh rate, or a framerate option in the video settings. This will allow for smooth and fluid gameplay on the refresh rate monitor.

Mockup

There can't really be a mockup for the automatic method, but this is what I'd imagine the framerate option would look like: image

Notes

It's possible there could be physics bugs that come from this, so it would be good to check up on stuff to make sure they don't break.

This can also currently be achieved in a locally built version by adjusting the physics framerate in the project settings.

Kuma-Boo commented 3 months ago

On a related note, Godot is planning to add 3D physics interpolation, so jittering on higher refresh monitors should be easily fixed when it comes out. https://github.com/godotengine/godot-proposals/issues/2753

Mickeon commented 3 months ago

To be specific, the PR that actually implements it is https://github.com/godotengine/godot/pull/92391 and is being tested around.