search

KumarManas04 / NotesSync

Notes Sync is the answer to your everyday note taking requirements. It can encrypt and sync everything to the user's own Google Drive or Dropbox accounts
MIT License
45 stars 14 forks source link

German translation, about version bugfix, html in changelog alert #3

Closed DerSaxxe closed 4 years ago

DerSaxxe commented 4 years ago

Also many hard coded strings moved to strings.xml Please update translation project at OneSky Thank you

DerSaxxe commented 4 years ago
  1. 'write_something' in the strings.xml is neither linked to the UI nor added to the english translation.

This is not correct. Please look at fragment_note_edit.xml

  1. 'other' in the strings.xml is neither linked to the UI nor added to the english translation.

This is not correct. Please look at fragment_settings.xml

  1. Translation of 'amoled' in german should be 'Amoled' and not 'Dark Mode' as it is a screen type

I think AMOLED is not the best choice because you can also set this theme on devices with other screen types than AMOLED. In german language "Dark Mode" should be better because most people knows what that means - deep black background. Why not?

  1. Remove quotes from 'encrypted_sync_summary' translation in german strings.xml

Done ;-)

KumarManas04 commented 4 years ago

Apologies for requests 1 and 2. I must have missed checking these.

I think AMOLED is not the best choice because you can also set this theme on devices with other screen types than AMOLED. In german language "Dark Mode" should be better because most people knows what that means - deep black background. Why not?

There is already a dark mode for normal screens but the Amoled mode is designed to increase battery efficiency on AMOLED screens since in that mode the screen is black at most parts. So users must know this. Hence, the name should be 'Amoled' only and not 'Dark Mode'.

DerSaxxe commented 4 years ago

What about "Black" since most common german people don't know what AMOLED means?

DerSaxxe commented 4 years ago
  1. The 'reminder_set' string should contain '\n' character. It was intentional.

Sorry this was not my mistake, seems to be a bug in the translation tool in android studio. I fixed it.

  1. Kindly remove 'auto_sync' and 'auto_sync_pref_summary' strings as they are no longer required.

I did it.

KumarManas04 commented 4 years ago

Great work @SIRSteiner Thanks for your time