search

KumarRobotics / imu_vn_100

ROS driver for VN-100 of VectorNav Technologies
Apache License 2.0
46 stars 52 forks source link

ROS 2 Dashing cleanups #29

Closed clalancette closed 5 years ago

clalancette commented 5 years ago

This PR does a few more cleanups on the ROS 2 Dashing port. In particular:

  1. It has a bug fix to change VnEnsure to always throw an exception. VnEnsure is only called during setup, and if any of the things during setup fail, we really want the node to fail.
  2. It clarifies the debug logging around "Connect" so it is clear when we are trying to connect and when we actually succeeded in connecting.
  3. It changes the separator character for the parameters from / to .. This allows us to use a parameter hierarchy.
  4. It adds a default configuration file.
  5. It adds a default launch file.
versatran01 commented 5 years ago

I don't have ROS2 to test with, but I will still merge this. Thanks.

clalancette commented 5 years ago

I don't have ROS2 to test with, but I will still merge this. Thanks.

I tested with my VN100T and Dashing, and it seemed happy with these changes. Thanks for merging!