search

KumarRobotics / imu_vn_100

ROS driver for VN-100 of VectorNav Technologies
Apache License 2.0
46 stars 52 forks source link

Update parameter name for Node launch action #42

Closed christophebedard closed 1 year ago

christophebedard commented 3 years ago

node_executable was deprecated in Foxy in favour of executable (https://github.com/ros2/launch_ros/pull/140) and then removed in Galactic (https://github.com/ros2/launch_ros/pull/190).

This PR targets the dashing branch because that's the only ROS 2-related branch on this repo. If you create a rolling branch (i.e. a master branch for ROS 2) or a galactic branch (latest ROS 2 distro), then I can re-target the PR.

Signed-off-by: Christophe Bedard bedard.christophe@gmail.com

fcladera commented 3 years ago

We originally write this driver for ROS1. Would it still work after these modifications?

christophebedard commented 3 years ago

This PR targets the dashing (ROS 2) branch; it won't affect the master (ROS 1) branch.

Note that this PR shouldn't be merged into the dashing branch because this fix won't work for ROS 2 Dashing. It would be better to create a rolling branch (i.e. a master branch but for ROS 2).

clalancette commented 2 years ago

Friendly ping here; I think this is the only thing preventing this driver from being used on later ROS 2 distributions, like Rolling and Humble. @christophebedard 's advice is exactly right; we should create a rolling branch and then retarget this to rolling.

Alternatively, you could also give me write access here and I could do it. Since I did the initial port of this driver to ROS 2, I have the most context on it. Either way works for me.

versatran01 commented 2 years ago

@clalancette I will give you write access. Thanks!