KumarRobotics / ublox

A driver for ublox gps
BSD 3-Clause "New" or "Revised" License
453 stars 390 forks source link

Added CfgVALDEL, CfgVALGET & CfgVALSET messages #218

Closed khpenner closed 1 year ago

khpenner commented 1 year ago

Added the new configuration messages for protocol versions greater than 23.01

khpenner commented 1 year ago

Besides the style things I point out inline, when I go to compile this (against Iron) I'm getting the following error:

--- stderr: ublox_msgs                                         
In file included from /home/ubuntu/ublox_ws/src/ublox/ublox_msgs/include/ublox_msgs/serialization.hpp:36,
                 from /home/ubuntu/ublox_ws/src/ublox/ublox_msgs/src/ublox_msgs.cpp:32:
/home/ubuntu/ublox_ws/src/ublox/ublox_msgs/include/ublox_msgs/ublox_msgs.hpp:88:10: fatal error: ublox_msgs/msg/cfg_valdel.hpp: No such file or directory
   88 | #include <ublox_msgs/msg/cfg_valdel.hpp>

As a comparison, compiling the ros2 branch against Iron works just fine.

I don't have time to debug it right now, but that needs to be solved before we merge this in.

Sorry... I made some mistakes copying over code, I'll be more diligent checking stuff over next time

brandonbeggs commented 1 year ago

Looks like we are missing the following in ublox_msgs.hpp.

static const uint8_t VALDEL = ublox_msgs::msg::CfgVALDEL::MESSAGE_ID;
static const uint8_t VALGET = ublox_msgs::msg::CfgVALGET::MESSAGE_ID;
static const uint8_t VALSET = ublox_msgs::msg::CfgVALSET::MESSAGE_ID;

I created a pull request to @khpenner's fork that solves this compiler error. Is there something I can do to more directly advance this PR?

clalancette commented 1 year ago

I created a pull request to @khpenner's fork that solves this compiler error. Is there something I can do to more directly advance this PR?

I've applied your fixes, and pushed them here. With that, I can now locally compile this, so thanks for that! I'm going to do another review here.