search

Kumilachew-g / To-Do-List

4 stars 0 forks source link

Peer-to-peer code review #6

Open mullenlucas opened 2 years ago

mullenlucas commented 2 years ago

Hello Kumilachew, great work !

I would like to add a slight suggestion, based on an article I read the other day, comparing the innerHTML function to the createElement. So for example in this line https://github.com/Kumilachew-g/To-Do-List/blob/d5627197dd4bb2177ccf0d5f81458d26bbb8f419/src/modules/activities.js#L31

It is said that it is recommended to use createElement structure to avoid security issues, and also performs better and faster

Other than that, great code !

tamana-Balkhi commented 2 years ago

Hello Kumilachew, great work !

Patricio greeting

you did a great work, but i have some suggestion about this line of your code:

textInput.classList.toggle('update-item');

if you use add instead of toggle it would seems great