search

KunaalKumar / Sugsn

Explore and get recommendations for movies and tv shows
0 stars 0 forks source link

Memory leak CoordinatorLayout #10

Closed KunaalKumar closed 5 years ago

KunaalKumar commented 5 years ago

Possibly at Movies.mContainer

KunaalKumar commented 5 years ago

Cause seems to be an issue in the view models. Need to make sure no context is passed/stored in them.

KunaalKumar commented 5 years ago

Try using fragment transaction instead of navigation transactions for bottom navigation

KunaalKumar commented 5 years ago

Problem is definitely with all view models. Will need to reimplement them.

KunaalKumar commented 5 years ago

Problem is definitely with all view models. Will need to reimplement them.

I was wrong, issue isn't with view models but in fact with fragment transactions on the bottom nav bar as mentioned before. That being said, view model implementations need to be updated hence - #11

KunaalKumar commented 5 years ago

Problem is definitely with all view models. Will need to reimplement them.

I was wrong, issue isn't with view models but in fact with fragment transactions on the bottom nav bar as mentioned before. That being said, view model implementations need to be updated hence - #11

CoordinatorLayout leak was right all along. However the problem is probably in on of its child views.

KunaalKumar commented 5 years ago

Fixed in 29749c4