Kunde21 / markdownfmt

Like gofmt, but for Markdown.
MIT License
55 stars 7 forks source link

Refactored Renderer to be streamed and statelessness. #17

Closed bwplotka closed 3 years ago

bwplotka commented 3 years ago

Fixes: https://github.com/Kunde21/markdownfmt/issues/16

Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com

bwplotka commented 3 years ago

Tests are still failing, on it.

bwplotka commented 3 years ago

Local tests passing. Changed one test slightly as I did not get what's the rule behind such blank lining (:

PTAL!

karelbilek commented 3 years ago

wow :D you really digged into this

The logic is related to tight vs. untight markdown lists.

bwplotka commented 3 years ago

Thanks for the initial review!

I Will try to address comments in my free time, ~this week.

bwplotka commented 3 years ago

Tests are passing, I addressed comments as much as I could 🤗

Thanks for the review!

bwplotka commented 3 years ago

Thank you very much for your time, comments and merge.

BTW this work makes me believe even more in power of open source (:

Let me know if you need any help maintaining this lib going forward, happy to help 🤗

bwplotka commented 3 years ago

https://twitter.com/bwplotka/status/1340631041585909760 (:

karelbilek commented 3 years ago

now I look at the PR more closely and wow, again, good work :D

bwplotka commented 3 years ago

Yea, I had some time to kill that's for sure (: