search

Kunena / Kunena-Addons

Modules and plugins for Kunena 6.0.
https://www.kunena.org
7 stars 22 forks source link

[Kunena Latest] Conflict with language codes (part 2) #316

Open rich20 opened 1 week ago

rich20 commented 1 week ago

Step 1. Please change in mod_kunenalatest.xml line 154 https://github.com/Kunena/Kunena-Addons/blob/04fbead55eed1b05ba5b799769a9603476236921/modules/kunenalatest/mod_kunenalatest.xml#L154 from label="MOD_KUNENALATEST_PARAM_CATEGORYLIST_NONE" multiple="true" size="5"> to label="MOD_KUNENALATEST_PARAM_CATEGORYLIST" multiple="true" size="5">

Step 2. Remove line 62 in en-GB.mod_kunenalatest.ini https://github.com/Kunena/Kunena-Addons/blob/04fbead55eed1b05ba5b799769a9603476236921/modules/kunenalatest/language/en-GB/en-GB.mod_kunenalatest.ini#L62 and add these 2 strings instead MOD_KUNENALATEST_PARAM_CATEGORYLIST="Category list" MOD_KUNENALATEST_PARAM_CATEGORYLIST_ALL="All categories"

The result is somewhat clearer (see image). In this example, all categories are hidden. . Bildschirmfoto vom 2024-09-06 20-17-20

Pinkeltje commented 1 week ago

In this example, all categories are hidden.

In my test (with proposed changes) all categories are not hidden. Furthermore I don't think it makes sense to have an option to hide all categories. If you hide all categories there is no use in using the module.

rich20 commented 1 week ago

Not all categories are hidden even without these changes. For this suggestion I have only changed the text. But hiding does not work for individual categories either, which is why I have also created this ticket. https://github.com/Kunena/Kunena-Addons/issues/317 I don't want to judge whether it makes sense to hide all categories, as it has always been like this with All / None (display or no display).