search

Kunena / Kunena-Forum

Kunena Forum - Forum / Bulletin Board / Discussions component for Joomla - This is the 6.x/5.x main development branch. Please do not open issues regarding earlier versions of Kunena
https://www.kunena.org
GNU General Public License v3.0
1.75k stars 812 forks source link

New polls is created as expired by default #9579

Closed rich20 closed 5 months ago

rich20 commented 11 months ago

To Reproduce

  1. create a poll
  2. let the Poll life span field empty
  3. save the message

Result The new poll has expired

System information

Desktop

xillibit commented 11 months ago

I don't have that when i save the message i don't have an error message saying that poll has expired

rich20 commented 11 months ago

I have this problem on one of my test pages. There it also shows outdated codes, although Kunena 6.2.1-DEV is installed.

Deprecated: DateTimeImmutable::__construct(): Passing null to parameter #1 ($datetime) of type string is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 105

Deprecated: Creation of dynamic property Kunena\Forum\Site\Controller\Topic\Poll\TopicPollDisplay::$intervalTimeToLive is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 106

Deprecated: Creation of dynamic property Kunena\Forum\Libraries\Layout\KunenaLayout::$intervalTimeToLive is deprecated in .../libraries/kunena/src/Layout/KunenaBase.php on line 571 Poll: test (was ended )

xillibit commented 11 months ago

Deprecated: Creation of dynamic property Kunena\Forum\Site\Controller\Topic\Poll\TopicPollDisplay::$intervalTimeToLive is deprecated in .../components/com_kunena/src/Controller/Topic/Poll/TopicPollDisplay.php on line 106

The following commit : https://github.com/Kunena/Kunena-Forum/commit/c8881c459b1bcd410b15782890558bf7d0128330 should fix that

rich20 commented 11 months ago

Partial success. The "Deprecated: DateTimeImmutable..." is now gone

xillibit commented 11 months ago

I don't reproduce this issue with J!5.0 and Php 8.2.x and MySQL 8.0 :

https://github.com/Kunena/Kunena-Forum/assets/876395/c7c24c64-7aba-40d8-a9d0-2b0d7a77eea7

rich20 commented 11 months ago

I believe you. Apparently, outdated code is not always displayed. In the case of this error https://github.com/Kunena/Kunena-Forum/issues/9562, nobody was able to confirm it for a long time, and yet it was actually there.

One message has now disappeared again with the last correction.

github-actions[bot] commented 10 months ago

This issue is stale because it has been open 30 days with no activity.

810 commented 5 months ago

@rich20 can you try again, then we can close this one

rich20 commented 5 months ago

Seems to be done