search

Kunena / Kunena-Forum

Kunena Forum - Forum / Bulletin Board / Discussions component for Joomla - This is the 6.x/5.x main development branch. Please do not open issues regarding earlier versions of Kunena
https://www.kunena.org
GNU General Public License v3.0
1.75k stars 812 forks source link

Fix: element (form) ID's must be unique on a page #9594

Closed Ruud68 closed 11 months ago

Ruud68 commented 11 months ago

Pull Request for Potential Issue

Summary of Changes

elements on a page should have a unique ID, currently the quick reply forms all have the same form ID. This can cause errors / conflicts when trying to do CSS / JS functions on these forms

Testing Instructions

install PR, test if everything is still working. Take special attantion when you have JS or CSS using the form ID "postform" as this ID now has been made unique with the message ID the postform is linked to.

rich20 commented 11 months ago

I still don't recognise any difference (tested with CAPTCHA - Invisible reCAPTCHA and Captcha - reCAPTCHA v3 from JED). I still have to deactivate the first captcha if I want the second one to be displayed. However, I get error messages (which have nothing to do with this fix), so I can only recognise which of the two captcha Kunena wants to display by the different error messages.

Ruud68 commented 11 months ago

Hi, this is not captcha related, that change I still need to do. First need to setup 6.3 Environment

rich20 commented 11 months ago

Hi, this is not captcha related, that change I still need to do. First need to setup 6.3 Environment

Thanks, yes I had noticed, that's why I labelled my post "off topic".