search

Kunena / Kunena-Forum

Kunena Forum - Forum / Bulletin Board / Discussions component for Joomla - This is the 6.x/5.x main development branch. Please do not open issues regarding earlier versions of Kunena
https://www.kunena.org
GNU General Public License v3.0
1.75k stars 812 forks source link

Refactor log clean view into modal making log controller / model / vi… #9637

Closed Ruud68 closed 7 months ago

Ruud68 commented 7 months ago

…ew obsolete

Pull Request for Issue # .

Summary of Changes

The Log model / controller / view / tmpl was only there for the logs clean function. I have moved that clean tmpl to a modal in the logs view. I have moved the clean function from the log controller to the logs controller.

Now the LogModel, LogController, Log view and Log Tmpl that where basically copies of the logs equivalents can be removed.

This PR removes the obsolete files from the repositorie bu NOT from an installation when updating. @xillibit when this PR is accepted then the removed files should also be cleaned up from the site where the update is installed. Can you do that in the script as i have no knowledge of that?

Testing Instructions

clean your logs in the log view and see if it is actually cleaned

xillibit commented 7 months ago

This PR removes the obsolete files from the repositorie bu NOT from an installation when updating. @xillibit when this PR is accepted then the removed files should also be cleaned up from the site where the update is installed. Can you do that in the script as i have no knowledge of that?

yes i will do it after i have tested and merged this PR

Ruud68 commented 7 months ago

@xillibit cool, please note that in order to test correctly you should already remove the files from the test environment (as updating the package with this PR doesn't do that)

Ruud68 commented 7 months ago

PS as for the deleting of the files, maybe (just an idea) it is best to have a script preflight routine that will remove the:

administrator/components/com_kunena:

Directories (and something similar for the kunena library directory and site component com_kunena directories)

This because I have also other 'left-over' / removed files on my production server from previous upates where not all removed files where also removed from the server it self.

Ruud68 commented 7 months ago

yeay! just did https://github.com/Kunena/Kunena-Forum/pull/9639 for the cleanup, had some time while waiting for a customer to give feedback :)