Kunena / Kunena-Forum

Kunena Forum - Forum / Bulletin Board / Discussions component for Joomla - This is the 6.x/5.x main development branch. Please do not open issues regarding earlier versions of Kunena
https://www.kunena.org
GNU General Public License v3.0
1.75k stars 814 forks source link

Proposal: replace Joomla user filters with custom user filter in logs view #9651

Closed Ruud68 closed 3 months ago

Ruud68 commented 3 months ago

Pull Request for Issue https://www.kunena.org/forum/k-6-3-0-support/168364-help-needed-logs-backend-view?start=0#230977 .

Summary of Changes

This PR replaces the two user filters (users / target users) in the logs view. Currently the filters are based on the Joomla core users field, this PR changes these fields to a customized dropdown filter where only users are listed that have an entry in the logs table.

Testing Instructions

This is a proposal, I like the Joomla core users field, but the added value here is very limited and it doesn't allow us to overwrite the label (select user > select target user)

Let me know what you think so @xillibit can either decline or merge (after testing)

cc @rich20

rich20 commented 3 months ago

For me, the user filter is fine as it is. But I have found problem, so I will create a new ticket for it.

Ruud68 commented 3 months ago

My preference is having the new filters as using the Joomla User fields can be confusing because they in label text do not differentiate between user and target user, further more the popup modal with all the filtering on the users is imo 'overkill'

rich20 commented 3 months ago