search

Kunena / Kunena-Forum

Kunena Forum - Forum / Bulletin Board / Discussions component for Joomla - This is the 6.x/5.x main development branch. Please do not open issues regarding earlier versions of Kunena
https://www.kunena.org
GNU General Public License v3.0
1.75k stars 814 forks source link

Fix: refactor plugin modals to dialogs to workaround J5.1 bug #9672

Closed Ruud68 closed 2 months ago

Ruud68 commented 2 months ago

Pull Request for Issue #9670 .

Summary of Changes

added new J5.1 dialogs when Joomla version is 5.1

Testing Instructions

test on both J5.1 and < J5.1

  1. in back-end goto Kunena > plugins
  2. click a plugin name

on J5.1 a dialog modal should open (save / save& close / close buttons on top on < J5.1 a BS modal should open (buttons in the footer)

  1. test if all buttons work.

The J5.1 plugin dialog modal is missing the Toggle inline help button (the BS modal has that button in the footer). I have crated a PR for that in the Joomla repository: appreciate if you could also test that and if okay report back as positive test result on the Joomla repository: https://github.com/joomla/joomla-cms/pull/43296

xillibit commented 2 months ago

It-is need to apply the PR4326 from Joomla! to test it ?

Ruud68 commented 2 months ago

It-is need to apply the PR4326 from Joomla! to test it ?

No, not needed. It should work without the Joomla PR.

The Joomla PR adds the button 'Toggle inline help' that is missing in the new 5.1 dialog modal. You can test that separately if you have time and energy to do so :)